Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting respective tde fork file with Drop Table #16

Closed
wants to merge 0 commits into from

Conversation

codeforall
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added a comment about a possible minor improvement.

char *rel_file_path;
char *key_file_path;

rel_file_path = relpathperm(rel->rd_locator, MAIN_FORKNUM);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could introduce a helper function this instead of doing the same logic in multiple functions.

@hqakhtar hqakhtar force-pushed the tuple_enc branch 2 times, most recently from 3d128f9 to 78c64b3 Compare September 13, 2023 15:31
@dutow
Copy link
Collaborator

dutow commented Sep 15, 2023

@codeforall could you please rebase on the now force-pushed tuple_enc branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants