Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing page pruning / compaction crash #15

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Commits on Sep 14, 2023

  1. Fixing page pruning / compaction crash

    Issue: the heap AM has a function which automatically compacts pages
    when certain conditions are met. When this happens, it moves the
    tuples around within the page. As encryption uses the offset of tuples
    for decrypting them, this results in garbage data and possible crashes.
    
    Fix: this commit copies the two compaction functions from the server code,
    and modifies them to re-encrypt data when moved. This is not optimized at
    all, if needed, we can improve this by a lot.
    
    Also, for now only one execution path is handled from the two, as that's
    the only one hit by sysbench. We'll have to figure out a testcase for
    the other and fix that too, for now, it only contains an assert(0).
    dutow committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    52655aa View commit details
    Browse the repository at this point in the history