Fix crash while deleting tuple w/ va attributes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the delete, we deform a tuple to create a new one with only Replica Identity attributes. Deforming - extracting attributes from the tuple, see `pg_tde_deform_tuple()` in `ExtractReplicaIdentity()` - needs to know the size of the variable length (va) attribute, which is in the va_header. As the va_header is the first N bytes of the actual data, the tuple has to be decrypted to read the attribute size. Closes percona#126
dutow
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the delete, we deform a tuple to create a new one with only Replica Identity attributes. Deforming - extracting attributes from the tuple, see
pg_tde_deform_tuple()inExtractReplicaIdentity()- needs to know the size of the variable length (va) attribute, which is in the va_header. As the va_header is the first N bytes of the actual data, the tuple has to be decrypted to read the attribute size.Closes #126