Updating the toasted column in encrypted table causes the crash (#82) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ona#82) pg_tde_toast_insert_or_update calls pg_tde_deform_tuple on old-tuple from within and tries to dereference the toast columns. Passing the encrypted tuple as part of the old tuple renders the toast data pointer (the encrypted value of the actual pointer) invalid, and anything can happen if it gets dereferenced as it is. The solution is to pass the decrypted old tuple pg_tde_toast_insert_or_update function from pg_tde_update.
dAdAbird
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_tde_toast_insert_or_update calls pg_tde_deform_tuple on old-tuple from within and tries to dereference the toast columns. Passing the encrypted tuple as part of the old tuple renders the toast data pointer (the encrypted value of the actual pointer) invalid, and anything can happen if it gets dereferenced as it is.
The solution is to pass the decrypted old tuple pg_tde_toast_insert_or_update function from pg_tde_update.