K8SPXC-1214: add .spec.backup.ttlSecondsAfterFinished field
#2234
+238
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
nmarukovich and
valmiranogueira
as code owners
egegunes
requested changes
Nov 21, 2025
deploy/cr.yaml
Outdated
| backup: | ||
| # allowParallel: true | ||
| image: perconalab/percona-xtradb-cluster-operator:main-pxc8.0-backup | ||
| # ttlSecondsAfterFinished: 60 |
Contributor
There was a problem hiding this comment.
people might understand this as a recommendation and 60 seconds is too short, especially for failed backups. let's make it something like 3600
Contributor
There was a problem hiding this comment.
And for example for restore we have the same problem. We run job and could delete it before the cluster becomes ready.
Comment on lines
114
to
134
| for _, jobName := range []string{ | ||
| naming.RestoreJobName(cr, false), | ||
| naming.RestoreJobName(cr, true), | ||
| } { | ||
| if err := k8sretry.RetryOnConflict(k8sretry.DefaultRetry, func() error { | ||
| job := new(batchv1.Job) | ||
| if err := r.client.Get(ctx, types.NamespacedName{ | ||
| Name: jobName, | ||
| Namespace: cr.Namespace, | ||
| }, job); err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| return nil | ||
| } | ||
| return errors.Wrap(err, "failed to get job") | ||
| } | ||
| job.Finalizers = slices.DeleteFunc(job.Finalizers, func(s string) bool { return s == naming.FinalizerKeepJob }) | ||
| return r.client.Update(ctx, job) | ||
| }); err != nil { | ||
| return reconcile.Result{}, errors.Wrap(err, "failed to remove keep-job finalizer") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
can we move this to a separate function like we do in backup controller?
Collaborator
commit: ff96f03 |
egegunes
approved these changes
Nov 25, 2025
hors
reviewed
Nov 25, 2025
| backup: | ||
| # allowParallel: true | ||
| image: perconalab/percona-xtradb-cluster-operator:main-pxc8.0-backup | ||
| # ttlSecondsAfterFinished: 3600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1214
DESCRIPTION
This PR adds a new field:
.spec.backup.ttlSecondsAfterFinished.The value will be applied to both backup and restore jobs.
To prevent breaking backup or restore processes when a small
ttlSecondsAfterFinishedvalue is used, a new finalizer,internal.percona.com/keep-job, has been introduced.This finalizer will be added to every backup and restore job and will be removed once the corresponding
pxc-backuporpxc-restoreresource reaches its finalSucceededorFailedstate.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability