Skip to content

K8SPG-799 configure imagepullsecrets for patroni version check pod - add envtests #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 28, 2025

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jun 26, 2025

K8SPG-799 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:

ImagePullSecrets are not configured for the patroni version check pod.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:

Wire properly the cr option imagePullSecrets with the patroni version check pod spec. Introduce related envtests to verify the behaviour. Ideally in the future we should extract the patroni version check pod construction from the controller and unit test is separately.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@gkech gkech marked this pull request as ready for review June 26, 2025 09:46
@JNKPercona
Copy link
Collaborator

Test name Status
backup-enable-disable passed
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
monitoring-pmm3 passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 21 out of 21

commit: d743e10
image: perconalab/percona-postgresql-operator:PR-1184-d743e1022

@hors hors merged commit c0aaf3d into main Jun 28, 2025
11 of 13 checks passed
@hors hors deleted the K8SPG-799 branch June 28, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants