Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-838 - Fix dataVolumeClaimSpec...storage in README #252

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

mrrsm
Copy link
Contributor

@mrrsm mrrsm commented Oct 12, 2023

instances.walVolumeClaimSpec.resources.requests.storage was duplicated for dataVolumeClaimSpec

@it-percona-cla
Copy link

it-percona-cla commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@egegunes
Copy link
Contributor

@mrrsm please bump the version

spron-in
spron-in previously approved these changes Jan 19, 2024
@mrrsm
Copy link
Contributor Author

mrrsm commented Jan 20, 2024

@egegunes Do you want a version bump for a docs only change?

@egegunes
Copy link
Contributor

@tplavcic does the requirement for bump caused by the lint-test check or does helm require bump for README change?

@tplavcic
Copy link
Member

tplavcic commented Jan 22, 2024

@egegunes @mrrsm Each change in helm charts triggers release so the version needs to be bumped since we cannot re-release old version. I agree it's a bit silly in this case, I'll check if chart releaser and linter can be configured differently, but for now it is like this.

@tplavcic tplavcic changed the title Fix dataVolumeClaimSpec...storage in README CLOUD-838 - Fix dataVolumeClaimSpec...storage in README Feb 1, 2024
@tplavcic
Copy link
Member

tplavcic commented Feb 1, 2024

Thank you very much for the contribution!

@tplavcic tplavcic merged commit d4da6d2 into percona:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants