PMM-13781 v3 missing MyRocks but still shows TokuDB #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitri-saricev-3pillargloball
requested review from
YashSartanpara1,
Copilot and
matejkubinec
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the obsolete TokuDB navigation menu item with MyRocks in the PMM v3 interface. TokuDB has been deprecated while MyRocks is actively used by customers in production environments.
- Replaces TokuDB navigation entry with MyRocks in the MySQL navigation menu
- Updates the dashboard URL path from
mysql-tokudbtomysql-myrocks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1 task
matejkubinec
approved these changes
Sep 30, 2025
dmitri-saricev-3pillargloball
deleted the
PMM-13781-v3-missing-MyRocks-but-still-shows-TokuDB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
TokuDB has been dead a long time. MyRocks is current, and customers are using it actively in production. PMMv3 navigation menu removed MyRocks, but kept TokuDB.
Recommend removing/hiding TokuDB from navigation menu, and replacing with MyRocks.
Which issue(s) this PR fixes:
https://perconadev.atlassian.net/browse/PMM-13781
Was:
Resolved issue:
Fixes #
Special notes for your reviewer:
FB
Percona-Lab/pmm-submodules#4052