PMM-12425 fix infinite loop for setting timerange #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashSartanpara1
requested review from
BupycHuk,
matejkubinec and
doracretu3pillar
matejkubinec
approved these changes
Nov 22, 2023
BupycHuk
approved these changes
Dec 7, 2023
| @@ -215,8 +216,13 @@ export const UrlParametersProvider = (props) => { | |||
| if (newTo === 'now') { | |||
There was a problem hiding this comment.
I think here should be 2 independent if else sections for from and for to
YashSartanpara1
added a commit
that referenced
this pull request
Feb 20, 2024
YashSartanpara1
added a commit
that referenced
this pull request
Apr 4, 2024
* PMM-12314 Migrate from toolkit * PMM-12314 Use node 18 * PMM-12425 fix infinite loop for setting timerange (#1544) * PMM-12425 fix infinite loop for setting timerange * PMM-12425 fix logic to set from time * PMM-12425 fix linting errors * PMM-12790 remove boomtable plugin (#1550) * PMM-12802 Remove carpetplot and piechart plugin * PMM-12802 update polystat to latest version * PMM-12802 remove old polystat panel * PMM-12802 Add geomap and upgrade polystat * PMM-12802 update polystat panels * PMM-12802 update polystat for mysql dashboard * PMM-12802 replace discrete plugin with timeline * PMM-12802 Remove discrete and worldmap plugins * PMM-12802 fix panels error and fonts * PMM-12802 Update font size --------- Co-authored-by: Matej Kubinec <[email protected]> Co-authored-by: Alex Demidoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12425 - QAN picking different date range will cause an error
Previous fixes should be tested after this fix -
PMM-9987
PMM-10483