Add Sharding Support to PSMDB Demand Backup Test #918
Conversation
ui/apps/everest/.e2e/release/demand-backup-psmdb-sharding.e2e.ts
Outdated
Show resolved
Hide resolved
ui/apps/everest/.e2e/release/demand-backup-psmdb-sharding.e2e.ts
Outdated
Show resolved
Hide resolved
ui/apps/everest/.e2e/release/demand-backup-psmdb-sharding.e2e.ts
Outdated
Show resolved
Hide resolved
| ); | ||
| }; | ||
|
|
||
| export const validateMongoDBSharding = async ( |
There was a problem hiding this comment.
Add parameter to this function for collection so you can just call it twice in the test with different collection parameter so that you don't duplicate the code for t1 and t2.
| ); | ||
|
|
||
| // Shard t1 | ||
| await queryPSMDB(cluster, namespace, 'test', 'db.t1.createIndex({ a: 1 });'); |
There was a problem hiding this comment.
Move createIndex to prepareMongoDBTestDB function.
| ); | ||
|
|
||
| // Shard t2 | ||
| await queryPSMDB(cluster, namespace, 'test', 'db.t2.createIndex({ b: 1 });'); |
There was a problem hiding this comment.
Move createIndex to prepareMongoDBTestDB function.
| cluster, | ||
| namespace, | ||
| 'test', | ||
| 'db.t2.insertMany([{ b: 1 }, { b: 2 }, { b: 3 }]);' |
There was a problem hiding this comment.
Please call the keys the same as in t1, so { a: 1 }, { a: 2 }, { a: 3 }. It will simplify things because we will have 1 function for configureMongoSharding which will just take parameter for collection.
| ); | ||
| }; | ||
|
|
||
| export const configureMongoDBSharding = async ( |
There was a problem hiding this comment.
Add parameter for collection name to this function and call it twice so that there is no code duplication for t1 and t2.
enableSharding can be called in the test directly or it can be left here because I don't think it will have any effect if the sharding is already enabled on the collection.
| queryTestDB, | ||
| } from '@e2e/utils/db-cmd-line'; | ||
|
|
||
| export let isShardingEnabled = false; |
There was a problem hiding this comment.
It seems strange exporting this from the test and importing it into helper functions. Let's create a function psmdbShardingEnabled in db-cmd-line.ts and then use it inside the same file.
| const isChecked = await shardingCheckbox?.isChecked(); | ||
| if (!isChecked) { | ||
| if (shardingCheckbox) { | ||
| isShardingEnabled = true; |
There was a problem hiding this comment.
When we create a new function in db-cmd-line.ts we don't need this here. Also we want to check if sharding is actually enabled in the backend (api call) and not did we just click on something in UI.
| // await moveForward(page); | ||
| }); | ||
|
|
||
| // Step to set number of shards |
There was a problem hiding this comment.
Remove comment since test description below has the same.
| //if (db != 'psmdb') { | ||
| // expect(addedCluster?.spec.proxy.replicas).toBe(size); | ||
| //} |
| ); | ||
| expect(addedCluster?.spec.engine.storage.size.toString()).toBe('1Gi'); | ||
| expect(addedCluster?.spec.proxy.expose.type).toBe('internal'); | ||
|
|
There was a problem hiding this comment.
Add something like:
expect(addedCluster?.spec.sharding.enabled).toBe(true)
expect(addedCluster?.spec.sharding.shards).toBe(2)
expect(addedCluster?.spec.sharding.configServer.replicas).toBe(3)
expect(addedCluster?.spec.proxy.replicas).toBe(3)
| expect(storageClasses.length).toBeGreaterThan(0); | ||
|
|
||
| await page.goto('/databases'); | ||
| await page.getByTestId('add-db-cluster-button').waitFor(); |
There was a problem hiding this comment.
i think this part should be moved to utils to avoid duplication 🤔 we call the cluster creation button in a lot of places
* First Version Readme 1.4.0 Everest * First Version Readme 1.4.0 Everest * First Version Readme 1.4.0 Everest * Fixing tittle * Fixing Typos and aligns * Fixing Typos * Fixing Typos * Hel Section finish * Hel Section finish * CLI Section finish * Update Readme for HELM * Udd link for our helm chardts * Update README.md Removing Notes
…e` flags (percona#991) * EVEREST-1794 Extend help description for `everestctl namespaces remove` flags * Revert go.sum * Fix formatting * Update commands/namespaces/remove.go Co-authored-by: Mayank Shah <[email protected]> * EVEREST-1794 Fix go mods after merge --------- Co-authored-by: Mayank Shah <[email protected]>
* chore: test upgrades RBAC * chore: test cluster creation RBAC * chore: test cluster creation RBAC * chore: update playwright * chore: refactor mock request * chore: test DB actions * feat: add code commands to add namespaces * fix: bad routing on cluster details * chore: test overview actions * chore: use kubectl to change permissions on tests * chore: apply kubectl for all permissions on tests * chore: test invisible actions * chore: remove unused var * chore: test backups * chore: test storages RBAC * chore: test schedules * chore: further schedules RBAC tests * chore: test restores RBAC * chore: further test restores RBAC * chore: refactor e2e RBAC utils * chore: rename setRBACPermissions fn * chore: simplify RBAC changes logic * chore: test new tests flow for RBAC * chore: improve RBAC test flow * fix: bash error * chore: remove unused var * chore: remove unused import --------- Co-authored-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
* EVEREST-1673 allow custom helm dir for db namespaces
…llation (percona#1008) Signed-off-by: Mayank Shah <[email protected]>
Demand backup test for PSMDB to include sharding:
The reference script for this implementation was: demand-backup.e2e.ts