Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1815 Replase AlecAivazis/survey lib with charmbracelet/bubbletea #1062

Merged
merged 34 commits into from
Feb 10, 2025

Conversation

maxkondr
Copy link
Contributor

@maxkondr maxkondr commented Jan 27, 2025

EVEREST-1815 Powered by Pull Request Badge

  • Replace AlecAivazis/survey lib with charmbracelet/bubbletea for interaction with user (confirm, survey, etc)
  • Update output styles
  • Separate functionality for gathering info from user, parsing and validating it from the main logic (processing the data and execute steps)
  • Fix issues with formatting
  • Fix issue with parsing default namespace in install CLI command
  • Disable sending Everest telemetry in tests and GH flows
  • add user password validation regex: ^[a-zA-Z0-9@*#$%^&+=!_-]{6,}$

@maxkondr maxkondr self-assigned this Jan 27, 2025
@maxkondr maxkondr marked this pull request as ready for review January 28, 2025 15:20
@maxkondr maxkondr requested a review from a team as a code owner January 28, 2025 15:20
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the new structure of CLI config, it feels more organized.
Left some of non-blocking comments

Copy link
Member

@mayankshah1607 mayankshah1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good overall.. personally, I liked the original [ ] checkbox more, is it possible to revert to that?

Screenshot 2025-01-30 at 3 47 23 PM

@recharte recharte merged commit 48bbf84 into main Feb 10, 2025
16 of 19 checks passed
@recharte recharte deleted the EVEREST-1815-bubbletea branch February 10, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants