Skip to content

Commit

Permalink
Fix windows taskbar context menu not popping up correctly
Browse files Browse the repository at this point in the history
Closes ppy#17965.

Note that this will cause a second osu! icon to appear after running the
application (after any update). As per the inline comment, this will
eventually be resolved via clowd/Clowd.Squirrel#24.

I do think having context menus working is more important than duplicate
icons.

Note that for anyone who already has a pinned taskbar icon, it will need
to be manually unpinned and repinned after a future update to actually
fix this issue.

Thanks to @caesay for help with investigation.
  • Loading branch information
peppy committed Apr 25, 2022
1 parent 2d1cc2e commit 7e9d51f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion osu.Desktop/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,12 @@ private static void setupSquirrel()
tools.RemoveUninstallerRegistryEntry();
}, onEveryRun: (version, tools, firstRun) =>
{
tools.SetProcessAppUserModelId();
// While setting the `ProcessAppUserModelId` fixes duplicate icons/shortcuts on the taskbar, it currently
// causes the right-click context menu to function incorrectly.
//
// This may turn out to be non-required after an alternative solution is implemented.
// see https://github.com/clowd/Clowd.Squirrel/issues/24
// tools.SetProcessAppUserModelId();
});
}

Expand Down

0 comments on commit 7e9d51f

Please sign in to comment.