Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BISERVER-15031] - Limit the PIR Export via REST API to the allowed types - null protection missing #5549

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[BISERVER-15031] - Limit the PIR Export via REST API to the allowed types - null protection missing #5549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions extensions/src/main/java/org/pentaho/platform/web/http/api/resources/RepositoryResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,8 +764,12 @@ protected Response doService( String contextId, String resourceId ) throws Objec
}

private boolean validatePrptiOutputFormat() {
String outputFormat = this.httpServletRequest.getParameterMap().get( "output-target" )[0];
return AllowedPrptiTypes.getByType( outputFormat ) != null;
boolean valid = true;
if ( this.httpServletRequest.getParameterMap() != null && this.httpServletRequest.getParameterMap().containsKey( "output-target" ) ) {
String outputFormat = this.httpServletRequest.getParameterMap().get( "output-target" )[0];
valid = AllowedPrptiTypes.getByType( outputFormat ) != null;
}
return valid;
}

abstract class CGFactory implements ContentGeneratorDescriptor {
Expand Down
Loading