Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDI-13846] REST step should have option to accept self-signed certs for HTTPS #9797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pentaho-aschurman
Copy link
Contributor

Added the UI widget to collect and store in the XML the "ignoseSSL" option, which was already in the main code. Tests were performed with Spoon over a server with certificate SSL.

@pentaho-aschurman pentaho-aschurman requested a review from a team as a code owner January 24, 2025 10:39
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

4 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 4 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (13.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: org.pentaho.di:pdi

View in SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

⚠️ Build finished in 29m 59s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl plugins/rest/core

⛔ Failed Tests

⛈️ 1 test(s) failed:

org.pentaho.di.trans.steps.rest.RestMetaTest.testLoadSaveRoundTrip (click to expand)

Unable to find getter for ignoreSSL

Tests run: 32, Failures: 1, Skipped: 0    Test Results


ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants