Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new tokens for Billboard 2025 refresh #878

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Adding new tokens for Billboard 2025 refresh #878

merged 4 commits into from
Feb 21, 2025

Conversation

marcagarcia
Copy link
Contributor

@marcagarcia marcagarcia commented Feb 21, 2025 •
edited
Loading

Adding new tokens for Billboard 2025 refresh

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-30ib8rhp9-penske-media-corp.vercel.app

Built with commit c37b50a.
This pull request is being automatically deployed with vercel-action

nayeonk
nayeonk approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@nayeonk nayeonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcagarcia marcagarcia merged commit 47bd2c4 into master Feb 21, 2025
3 checks passed
@marcagarcia marcagarcia deleted the feature/PMCP-6987 branch February 21, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeonk nayeonk nayeonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcagarcia @nayeonk