Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix twing version in root package as well #501

Merged
merged 7 commits into from
Apr 5, 2022

Conversation

jameswburke
Copy link
Contributor

@jameswburke jameswburke commented Apr 5, 2022

Summary

This is a follow up for #495 which includes the correct Twing version in the root package.json, along with general npm package updates.

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/penske-media-corp/pmc-larva/8bL7ukdsf847JohXvD447W7XRUz2
✅ Preview: In Progress

@jameswburke jameswburke changed the title Bug/gut 289/twing version Fix twing version in root package as well Apr 5, 2022
@jameswburke jameswburke merged commit 1436c32 into master Apr 5, 2022
@jameswburke jameswburke deleted the bug/GUT-289/twing-version branch April 5, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants