Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force [email protected] to temporarily work around bug in library #495

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Force [email protected] to temporarily work around bug in library #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
982377f
Force [email protected] to temporarily work around bug in library
jameswburke Apr 5, 2022
15ddcbb
Merge branch 'master' into bug/GUT-289/twing-version
jameswburke Apr 5, 2022
54e648e
Update changelog
jameswburke Apr 5, 2022
acbf624
Add helper scripts for running npm link and rebuilt package-lock
jameswburke Apr 5, 2022
14d96a2
Revert updated package-lock.json in root to bypass pixel shifting bac…
jameswburke Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* larva-patterns - Add `article-callout` module.
* larva-patterns - Update `c-email-field` component and 'newsletter' module to improve label and input accessibility.
* all - Add github action on workflow-dispatch to update the visual regression tests in the same environment in which they are run

* larva - Lock the twing package to version 5.1.0 to temporarily work around bug in library.

## 0.5.6 - 03-29-2022
* larva-tokens - Add desktop_xl token values in typography.json
Expand Down
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@
"sync-tokens": "mkdir -p build/tokens && cp -r packages/larva-tokens/build/ build/tokens/",
"sync-public": "mkdir -p packages/larva/public && cp -r public packages/larva",
"sync-built-js": "mkdir -p build/js/standalone && rm -r build/js/standalone && cp -r packages/larva-js/build build/js/standalone",
"sync-build": "npm run sync-public && npm run sync-tokens && npm run sync-built-js && mkdir -p packages/larva/build && rm -r packages/larva/build && cp -r build/ packages/larva/build"
"sync-build": "npm run sync-public && npm run sync-tokens && npm run sync-built-js && mkdir -p packages/larva/build && rm -r packages/larva/build && cp -r build/ packages/larva/build",
"link-all": "npm run prod && npm run link-larva && npm run link-patterns && npm run link-css && npm run link-js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 Can you update confluence to include these commands as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, https://confluence.pmcdev.io/display/ENG/How+to+test+changes+to+Larva+packages+locally+using+npm+link

"link-larva": "cd packages/larva && npm link",
"link-patterns": "cd packages/larva-patterns && npm link",
"link-css": "cd packages/larva-css && npm link",
"link-js": "cd packages/larva-js && npm link"
},
"bin": {
"larva": "packages/larva/bin/larva.js"
Expand Down
Loading