Aaron/rf2 refactor #643
Merged
Aaron/rf2 refactor #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rxjava1 to retrofit 2 Remove rxjava2 Update gradle version Update agp
…f2-refactor # Conflicts: # PennMobile/src/main/java/com/pennapps/labs/pennmobile/api/StudentLifeRf2.kt
Note: Polls were not tested, since they don't exist.
Improve xml by hardcoding some known values.
Improve xml by hardcoding some known values.
meiron03
requested review from
baronhsieh2005,
vavali08,
Divak2004,
trinif and
joemacd
baronhsieh2005
approved these changes
Feb 2, 2025
PennMobile/src/main/java/com/pennapps/labs/pennmobile/gsr/fragments/GsrFragment.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully upgrade network requests to Retrofit2 by removing Retrofit from codebase.
Also includes small laundry view optimizations.