Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coded dining insight start date + Removed bottom bar for news fragment #623

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Coded dining insight start date + Removed bottom bar for news fragment #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a10c81a
Coded dining insight start date + removed bottom bar for news fragment
baronhsieh2005 Sep 1, 2024
0d6b33a
Lint (Love you Rohan)
baronhsieh2005 Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions PennMobile/src/main/java/com/pennapps/labs/pennmobile/NewsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@ class NewsFragment : ListFragment() {
@JvmStatic val CUSTOM_TAB_PACKAGE_NAME = "com.android.chrome"
}

private var mListView: ListView? = null
private var mCustomTabsClient: CustomTabsClient? = null
private var customTabsIntent: CustomTabsIntent? = null
private var share: Intent? = null
private var session: CustomTabsSession? = null
private var _binding: FragmentNewsBinding? = null
private var builder: CustomTabsIntent.Builder? = null
private var connection: NewsCustomTabsServiceConnection? = null
private var customTabsIntent: CustomTabsIntent? = null
private var isCustomTabsSupported: Boolean = false
private var mCustomTabsClient: CustomTabsClient? = null
private var mListView: ListView? = null
private var session: CustomTabsSession? = null
private var share: Intent? = null
private lateinit var mActivity: MainActivity
private lateinit var sharedPreferences: SharedPreferences

private var connection: NewsCustomTabsServiceConnection? = null

private var _binding: FragmentNewsBinding? = null
val binding get() = _binding!!

internal inner class CustomListAdapter(
Expand Down Expand Up @@ -162,7 +162,7 @@ class NewsFragment : ListFragment() {

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
val mActivity = activity as MainActivity
mActivity = activity as MainActivity
mActivity.closeKeyboard()
setHasOptionsMenu(true)

Expand All @@ -175,6 +175,7 @@ class NewsFragment : ListFragment() {
savedInstanceState: Bundle?,
): View {
_binding = FragmentNewsBinding.inflate(inflater, container, false)
mActivity.hideBottomBar()
return binding.root
}

Expand Down
2 changes: 1 addition & 1 deletion PennMobile/src/main/java/com/pennapps/labs/pennmobile/adapters/DiningInsightsCardAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class DiningInsightsCardAdapter(
private const val DINING_DOLLARS_PREDICTIONS = 2
private const val DINING_SWIPES_PREDICTIONS = 3

const val START_DAY_OF_SEMESTER = "2024-01-18"
const val START_DAY_OF_SEMESTER = "2024-08-27"
private const val DAYS_IN_SEMESTER = 117f
}

Expand Down
Loading