Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase authed/non-authed clarity for mobile view, change wording on "Add Club" button #737

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Increase authed/non-authed clarity for mobile view, change wording on "Add Club" button #737

merged 2 commits into from
Oct 13, 2024

Conversation

julianweng
Copy link
Member

@julianweng julianweng commented Oct 13, 2024 •
edited
Loading

This PR does a couple things to make the user flow a little clearer:

  1. Shows the login button on the navbar for mobile users versus hidden in the menu, making it more obvious when users aren't signed in (we have received support requests where users were simply not signed in on mobile but were unaware)
  2. Rename the "Add Club" button to "Register Club" to make its purpose more specific and signals the fact that Penn Clubs is the official OSA-sponsored platform for new clubs to register on
  3. Makes the login button equally spaced with the other links in desktop view (this one is gratuitous)

Before/After (Desktop)

desktop screenshot before changes

desktop screenshot after changes

Before/After (Mobile)

mobile screenshot before changes

mobile screenshot after changes

aviupadhyayula
aviupadhyayula approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up Julian, great work 🚀

frontend/components/Header/index.tsx Outdated Show resolved Hide resolved
@julianweng julianweng merged commit c888c78 into master Oct 13, 2024
3 checks passed
@julianweng julianweng deleted the login-status-misc-clarity branch October 13, 2024 17:44
rm03 pushed a commit that referenced this pull request Oct 15, 2024
@julianweng @rm03
Increase authed/non-authed clarity for mobile view, change wording on…
eaf1815 
… "Add Club" button (#737)

Make login button more prominent in mobile view, change wording for Add Club
@aviupadhyayula aviupadhyayula mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviupadhyayula aviupadhyayula aviupadhyayula approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianweng @aviupadhyayula