Ticketing #501

rohangpta · 2022-01-16T19:01:28Z

Mega PR for Ticketing project

Ticket administrators

Create initial ticket offerings (PUT api/events/<event_id>/tickets) (idempotency/editable)
View individual ticket information (for confirmation page) (GET api/ticket/<ticket_id>)
Generate QR code for ticket with link to confirmation page (GET api/ticket/<ticket_id>/qr)
View ticket counters (available, totals) and buyers (GET api/events/<event_id>/tickets). Buyers are viewable only by officers of club. (GET api/events/<event_id>/buyers).

Ticket buyers

Atomic add to cart (POST api/events/<event_id>/add_to_cart)
List owned tickets (GET api/tickets)
Atomic remove from cart (POST api/events/<event_id>/remove_from_cart)
Atomic checkout (initiate 10 minute hold on tickets in cart) (POST api/tickets/checkout)
View and validate cart (try to replace ticket instances that have been sold out). (GET api/tickets/cart)
Ticket buy callback (update ownership, send confirmation email (POST api/tickets/buy)

Misc

codecov · 2022-01-17T22:07:47Z

Codecov Report

Attention: Patch coverage is 91.50943% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 71.00%. Comparing base (d199a7e) to head (e1fac0b).
Report is 8 commits behind head on master.

Files	Patch %	Lines
...s/management/commands/expire_membership_invites.py	33.33%	2 Missing ⚠️
...nd/clubs/management/commands/update_club_counts.py	33.33%	2 Missing ⚠️
backend/clubs/serializers.py	84.61%	2 Missing ⚠️
...nd/clubs/management/commands/find_broken_images.py	50.00%	1 Missing ⚠️
backend/clubs/models.py	98.41%	1 Missing ⚠️
backend/clubs/permissions.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   69.78%   71.00%   +1.21%     
==========================================
  Files          31       31              
  Lines        6387     6804     +417     
==========================================
+ Hits         4457     4831     +374     
- Misses       1930     1973      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cphalen

All gas no breaks. Well done Rohan!

cphalen · 2022-01-18T20:41:42Z

backend/clubs/views.py

+        buyers = tickets.filter(owner__isnull=False).values("id", "fullname", "type")
+
+        return Response({"totals": totals, "available": available, "buyers": buyers})


Buyers probably shouldn't be public because we don't want everyone to know who owns tickets. I don't think it's a huge deal but would be weird if I could like track you down and know for certain that you're doing to show. Maybe just show the user their own tickets or something? I like totals and available though.

Never mind, my bad I didn't realize this viewset had a permission class — this is perfect!

…cart views

…out and updated when any cart is validated before checkout

…ot yet exist

… adding to cart

backend/clubs/views.py

* Merge master into ticketing * Move ticketing migration to end

gitguardian · 2024-02-13T05:39:31Z

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10282361	Triggered	Generic High Entropy Secret	`428dd7e`	backend/pennclubs/settings/development.py	View secret
9451515	Triggered	Generic Password	`50b9c0b`	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
9451515	Triggered	Generic Password	`03214af`	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
9451515	Triggered	Generic Password	`80e8201`	.github/workflows/cdkactions_build-and-deploy.yaml	View secret
10282361	Triggered	Generic High Entropy Secret	`40fb7f7`	backend/pennclubs/settings/ci.py	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

* Owned tickets tab skeleton code. * 🎉 Functional but suspicious code * 🧹 Fix some good practice --------- Co-authored-by: Julian Weng <[email protected]>

* Add test cases for backend ticketing APIs Long overdue addition of tests to the ticketing backend. Tests and fixes all the APIs under the Event and Ticket models. There are more complex workflows with race conditions etc that are not tested, but should be at some point. Unmerged functionality is also not tested yet. * Don't use locked rows to groupby * Set cybersource settings in CI * Address feedback

* Add to cart feature (styling is borked) * 🐛 Broken code * 🐛 fixed * 🎨 Readd event preview * 🧹 Less jank way of doing group discount visibility * 🎨 Address comments and actually type things * 🎨 Address nit --------- Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Eunsoo Shin <[email protected]>

* Use capture context to verify transient token * Add migration * Minor changes to documentation * Add tests * Add comment explaining max char length

* Add ticket drop time to event attributes * Set ticket drop time at tickets creation * Add unit tests * Minor refactor to tests * Revert unneeded changes to Pipfile.lock * Allow users to specify drop time + more guards/tests * Remove dev artifact in tests * Fix all typos with "transferred" * Add 403 to response schema * Only display tickets after they've dropped

* add ability to transfer tickets * send confirmation emails on transfer * nit * address comments, add ticket creation serializer * fix migration * remove print statement 😔 * grrr * remove serializer, add tests * tests + fix * here at Penn Clubs, we love nits * lint

* Cart skeleton * Basic UI to payment. * More appropriately-sized shopping cart icon * Payment integration 1st step. * fix(move) * fix(TicketCard): extract and abstract * checkout flow ui * wip(payment) * 🎉 Add ability to remove tickets from cart * 🐛 Better backend error and remove cart logic * 🎉 Modify sold_out to return event type and count * 🎉 Add cart empty view and edit mode * 🎨 Add empty view * 🎨 Grafik design is my passion * 🎉 Modify edit success and display toast, correct e2e behavior * 🐛 Change color to make edit mode more obvious * 🎉 Toast for sold out tickets * Add frontend auth check to cart page and fix sold_out toast functionality (multiple toasts per ticket, ticket event name) * Fix backend tests for group discounts, new cart API, and more (#675) * Refactor cart summation to helper fn * Add tests for group discounts and cart totaling * Minor change to docs * Only populate `sold_out_tickets` if tickets cannot be replaced * Refactor tests to use new cart API * Make openAPI docs happy * Make `_calculate_cart_total` static method * Group discount shouldn't activate below threshold * Fix API docs & improve tests * Add minor subtest * Align tests with new API * Improve invalid ticket replacement * 🎉 Default to 1 ticket when buying smh * 🎉 Add a bunch of style and features * 🎨 Kinda responsive --------- Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Eunsoo Shin <[email protected]> Co-authored-by: Avi Upadhyayula <[email protected]> Co-authored-by: aviupadhyayula <[email protected]>

* Move guards on event deletion to the right place * Add @update_holds to destroy * Fix typo in testing docs * Test guards on event deletion * Improve test case logic * Address nit in tests

* Add issues_ticket route * Improve efficiency * Add tests for `issue_tickets` * Minor refactor to tests * Create transaction records after issuing * Make unit test more exhaustive * Return errors as array in response * Lock issue_tickets behind perms * Revert "Lock issue_tickets behind perms" This reverts commit 47e63b0. * Remove unnecessary holds * Change input schema naming * Auth lock issue_tickets route * Add test for perms

* attendance tracking * add comment

* Fix ticket interface for sellers. * Clarify type for buyersPerm. * 🎨 Yay * Frontend for admin ticket transfering and base props fix. * 🎉 Add issue ticket * Frontend for marking tickets as attended/not attended * 🎨 Split String and handle input edge case * 🧹 Hehe * 🚨 Some changes with a fake api endpoint * 🎉 Some fire UI * 🐛 Error Response not showing correctly * 🎨 Brr * Lint, improve UI language, fix items remaining in cart after deletion through button, fix updating item quantities in cart through button, fix success vs error toast for adding tickets to cart. * API integration for issuing tickets * Ticket transfer interface * Integrate attendance into frontend and add warning popup for un-attending people * 🎨 Nit * 🐛 Joy fixes everything --------- Co-authored-by: Joy Liu <[email protected]> Co-authored-by: Joy Liu <[email protected]>

* Added support for free tickets * fix lint error * fix lint error * Added free ticket tests * Address feedback * Address feedback * Add user a parameter to _give_tickets

…ta (#685) * Add buyable field and try to enforce it. Disable tickets with payments on frontend. * Add frontend handling for no-cost cart.

* Add beta tag everywhere and add frontend auth check for issuing tickets * Delete legacy events code

* fix expires_at test test (#664) * Cast exception to str in management command * Move submissions from /apply to user profile (#638) * finished changes * Remove Wharton applications from user profile (and update branch) (#641) * Update main.ts * Update frontend dependencies (#616) Upgrade from Node 14 to Node 20 and bump frontend dependency versions to current. --------- Co-authored-by: Julian Weng <[email protected]> * Update README.md * Update README backend instructions and intro blurb * Fix admin page access on frontend. (#626) Add frontend check for existing pre-loaded permissions on /admin. * Removed deprecated QuestionResponse model and duplicate line (#625) * Remove deprecated QuestionResponse model * remove duplicate line: 'rank field in Club' * made migrations after deleting QuestionResponse * Streamline django storages config (#618) * Add staticfiles * Fix AWS bucket routing for boto * Try setting credentials through env vars * Try renaming env vars? * Set AWS region * add back staticfiles * Remove region and signature version * Move credentials to new API * Use env variables and remove staticfiles * Add back staticfiles * Make code look pretty --------- Co-authored-by: Rohan Moniz <[email protected]> * Add hour to displayed application deadline (#628) * Add hour for application due dates * Make linter happy * Specify Eastern time zone * Display username if name is empty (#637) * finished changes * Remove Wharton applications from user profile * Fix weird artifacts from merge --------- Co-authored-by: Joy Liu <[email protected]> Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Rohan Moniz <[email protected]> Co-authored-by: Thomas Ngulube <[email protected]> Co-authored-by: Owen Lester <[email protected]> * Bump debounce timeout to 400ms (#640) * Bump debounce timeout to 400ms * Make linter happy * small changes * added type * merging * deleted file --------- Co-authored-by: Avi Upadhyayula <[email protected]> Co-authored-by: Joy Liu <[email protected]> Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Rohan Moniz <[email protected]> Co-authored-by: Thomas Ngulube <[email protected]> * Add carousel (#622) * add carousel * Old react-multi-carousel * fixed npm yarn * remvoed packagelock.json * fixing issues * change height * minor changes * deleted a comment * merging? * delete one onClick * change breakpoint * Revert "Move submissions from /apply to user profile (#638)" (#673) This reverts commit 29d9a12. * Revert "Add carousel (#622)" (#674) This reverts commit fcab615. * Improve error reporting in mgmt cmds (#678) * Fix bug in Excel column names (#683) * Remove unused `tickets_count` field --------- Co-authored-by: Thomas Ngulube <[email protected]> Co-authored-by: owlester12 <[email protected]> Co-authored-by: Joy Liu <[email protected]> Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Rohan Moniz <[email protected]>

rohangpta requested a review from cphalen January 17, 2022 22:09

cphalen approved these changes Jan 18, 2022

View reviewed changes

rohangpta force-pushed the ticketing branch from 358e4fd to df42cbd Compare October 2, 2022 17:26

rohangpta force-pushed the ticketing branch from c626d94 to e1c9172 Compare October 16, 2022 17:37

cphalen and others added 21 commits November 12, 2022 14:54

Ticket model

074fda5

some basic untested functionality

4171a61

tested routes, added view ticket count route

ef872be

lint

c55fd75

email confirmation, qrcode, retrieve ticket

2d0db0d

remove commented stuff

7240a11

created cart model and add to cart, validate cart, and checkout from …

ae99446

…cart views

added holding expiration functionality, holding is initiated at check…

0a975fb

…out and updated when any cart is validated before checkout

lint and tests

7fe194d

added cart creation for a user upon adding to a cart if a cart does n…

ac0975a

…ot yet exist

slightly changed holding updates, added update to holding status when…

c69254a

… adding to cart

atomic transactions, cleanup, and some views

5382f48

holding, validation improvements, perms

6508a97

some docstring stuff

9610747

rebase + pipfile lock

c9fb115

use master pipfile.lock

1b0bda8

lint and pre-commit fixes

094ad42

minor bugs

d67a3a6

add to populate script

a352b01

lint

7367db1

rebase, fix some documentation

7f650dc

rohangpta force-pushed the ticketing branch from 42edba0 to 7f650dc Compare November 12, 2022 20:13

rohangpta commented Nov 13, 2022

View reviewed changes

backend/clubs/views.py Outdated Show resolved Hide resolved

Update ticketing (backend) branch (#612)

03214af

* Merge master into ticketing * Move ticketing migration to end

joyliu-q and others added 28 commits April 16, 2024 18:11

Owned Tickets Tab in Settings (#663)

27ac7c6

* Owned tickets tab skeleton code. * 🎉 Functional but suspicious code * 🧹 Fix some good practice --------- Co-authored-by: Julian Weng <[email protected]>

Rm console.log on frontend

6f75d48

Use capture context in cart checkout (#671)

78f02fd

* Use capture context to verify transient token * Add migration * Minor changes to documentation * Add tests * Add comment explaining max char length

fix N+1 query due to attribute

212720b

Fix breaking changes introduced in #670 (#680)

3888a5c

Add guards on ticketed event deletion (#667)

ad28028

* Move guards on event deletion to the right place * Add @update_holds to destroy * Fix typo in testing docs * Test guards on event deletion * Improve test case logic * Address nit in tests

Default billing phone number to null

fb4e4cf

Basic mobile responsiveness for TicketCard

71e1fbc

Add route for attendance tracking (#684)

b57d797

* attendance tracking * add comment

✨ feat(checkout): cybersource integration

ffea49a

🎨 It's toast time

a614997

🛠️ fix(close): handle modal close with confirm

5f4716a

✨ feat(success): checkout success message

4076a4f

❌ feat(handle error)

21eceff

🛠️ fix(message): more explicit message for modal close confirmation

5d13f9b

Fix lint, min/max add to cart quantities per class

d032c7a

Add support for free tickets (#658)

a1b694d

* Added support for free tickets * fix lint error * fix lint error * Added free ticket tests * Address feedback * Address feedback * Add user a parameter to _give_tickets

⬇️ Downgrade Eslint dependency

32dd60d

Add ability to make tickets not buyable + disable paid tickets for be…

1c4d9ef

…ta (#685) * Add buyable field and try to enforce it. Disable tickets with payments on frontend. * Add frontend handling for no-cost cart.

Ticketing Beta branding and File Cleanup (#686)

ff74f68

* Add beta tag everywhere and add frontend auth check for issuing tickets * Delete legacy events code

rohangpta merged commit d2e5758 into master Apr 29, 2024
6 of 7 checks passed

rohangpta deleted the ticketing branch April 29, 2024 03:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ticketing #501

Ticketing #501

rohangpta commented Jan 16, 2022 •

edited

Loading

codecov bot commented Jan 17, 2022 •

edited

Loading

cphalen left a comment

cphalen Jan 18, 2022

cphalen Jan 18, 2022

gitguardian bot commented Feb 13, 2024 •

edited

Loading

		buyers = tickets.filter(owner__isnull=False).values("id", "fullname", "type")

		return Response({"totals": totals, "available": available, "buyers": buyers})

Ticketing #501

Ticketing #501

Conversation

rohangpta commented Jan 16, 2022 • edited Loading

Ticket administrators

Ticket buyers

Misc

codecov bot commented Jan 17, 2022 • edited Loading

Codecov Report

cphalen left a comment

Choose a reason for hiding this comment

cphalen Jan 18, 2022

Choose a reason for hiding this comment

cphalen Jan 18, 2022

Choose a reason for hiding this comment

gitguardian bot commented Feb 13, 2024 • edited Loading

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

rohangpta commented Jan 16, 2022 •

edited

Loading

codecov bot commented Jan 17, 2022 •

edited

Loading

gitguardian bot commented Feb 13, 2024 •

edited

Loading