Change remove_clubs_from_exception to detail=false, fix checkbox stat…

…e management
pennlabs · Dec 1, 2023 · 4a817c6 · 4a817c6
1 parent 901bea1
commit 4a817c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/backend/clubs/views.py b/backend/clubs/views.py
@@ -5098,7 +5098,7 @@ def add_clubs_to_exception(self, *args, **kwargs):
         )
         return Response([])
 
-    @action(detail=True, methods=["post"])
+    @action(detail=False, methods=["post"])
     def remove_clubs_from_exception(self, *args, **kwargs):
         """
         Remove selected clubs from application cycle deadline exemption

diff --git a/frontend/components/Settings/WhartonApplicationCycles.tsx b/frontend/components/Settings/WhartonApplicationCycles.tsx
@@ -112,13 +112,10 @@ const WhartonApplicationCycles = (): ReactElement => {
       })
     }
     if (clubsNoExceptions.length > 0) {
-      doApiRequest(
-        `/cycles/${extensionsCycle.id}/remove_clubs_from_exception/`,
-        {
-          method: 'POST',
-          body: { clubs: clubsNoExceptions.map((x) => x.id) },
-        },
-      )
+      doApiRequest(`/cycles/remove_clubs_from_exception/`, {
+        method: 'POST',
+        body: { clubs: clubsNoExceptions.map((x) => x.id) },
+      })
     }
   }
 
@@ -132,7 +129,7 @@ const WhartonApplicationCycles = (): ReactElement => {
           }),
         )
       })
-  }, [clubOptionsMembership])
+  }, [])
 
   useEffect(() => {
     if (membershipCycle && membershipCycle.id != null) {
@@ -264,13 +261,13 @@ const WhartonApplicationCycles = (): ReactElement => {
                               setClubsExtensions([...clubsExtensions])
                             }}
                           />
-                          {/* {club.endDate} */}
                         </td>
                         <td>
                           <Checkbox
                             onChange={(e) => {
                               club.exception = e.target.checked
                               club.changed = true
+                              setClubsExtensions([...clubsExtensions])
                             }}
                             checked={
                               club.exception != null ? club.exception : false