Add circulating supply endpoint #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanS98
approved these changes
Feb 20, 2024
| } else { | ||
| console.error("Invalid network"); | ||
| } | ||
| // Supply to ignore is the sum of the free - frozen of the accounts to substract |
There was a problem hiding this comment.
Can you please rephrase this comment a bit so that's easier to understand? More like explaining why we do this first, then explaining how we do it. It's just a suggestion though, I don't mind leaving it like this.
There was a problem hiding this comment.
Rephrased. Please let me know if it still not so clear.
There was a problem hiding this comment.
That's better, I left one more suggestion.
bogdanS98
reviewed
Feb 21, 2024
ebma
reviewed
Feb 22, 2024
Co-authored-by: Marcel Ebert <[email protected]>
ebma
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original task #242
As discussed in the issue, we will define the circulating supply to be equal to the total transferable amount subtracted by the total transferable of the multi-sig accounts.
Implementation
We have already defined the total transferable to be the
free - frozenbalance. In this PR we just mantain a new variable calledsupplyToIgnoreand during account iteration, we count the transferable amount contribution of the accounts we want to ignore, so the total circulation will end up beingtotalTransferable - supplyToIgnore.