Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the farming smart contract for Nabla #373

Open
1 task
prayagd opened this issue Dec 8, 2023 · 12 comments
Open
1 task

Deploy the farming smart contract for Nabla #373

prayagd opened this issue Dec 8, 2023 · 12 comments
Labels
state:on-hold feature/fix is on hold due to external reasons (please specify)

Comments

@prayagd
Copy link
Collaborator

prayagd commented Dec 8, 2023

Context

In order to enable farming and distribute rewards to the Nabla LP's. We want to deploy the farming smart contract on Pendulum. This is the follow up ticket of the research done on this smart contract whether it is compatible with Pendulum, results can be found here.

tl;dr -
Can it be compiled to WASM?
It is. With only a minor modification. It was compiled and deployed to foucoco-standalone using wasm-deploy. Along with the SafeERC20 contract which is already implemented by Nabla

Requirement

  • Deploy it on Pendulum

Notes

  • Should be first deployed on Foucoco and tested there before deploying on Pendulum.
@prayagd
Copy link
Collaborator Author

prayagd commented Dec 8, 2023

@ebma @gianfra-t Please check and let me know if anything missing. Also i assume you would need certain parameters that needs to be configures in this smart contract, if you can help me with what are those? i can get this ticket ready for execution.

@ebma
Copy link
Member

ebma commented Dec 8, 2023

@prayagd as far as I can tell the things we need are mentioned here. We need to know:

  • ERC20 contract used for the rewards -> the ie. the token we want to use to pay rewards
  • Rewards per block
  • Initial Start and end block where rewards will be distributed
  • deposit fee -> the relative fee a user needs to pay when depositing LP tokens. The fee is paid in LP tokens
  • Fee Address -> the address where the LP tokens charged as a fee are transferred

@prayagd
Copy link
Collaborator Author

prayagd commented Dec 8, 2023

@ebma ok, will get you these parameters but would this be required to deploy it on foucoco and test the rewards? If not can we progress on foucoco then?

@gianfra-t
Copy link
Contributor

Yes those things we need to pass when creating the contract. But I imagine we could deploy in foucoco with some mock values to test the contract.

@ebma
Copy link
Member

ebma commented Dec 8, 2023

Yeah, we could test without knowing the production parameters by choosing some values ourselves. But it would make more sense to test with the parameters that you eventually want to use also in production 😅

@prayagd
Copy link
Collaborator Author

prayagd commented Dec 11, 2023

Ok, putting this on hold i until i get the production values

@prayagd prayagd added the state:on-hold feature/fix is on hold due to external reasons (please specify) label Dec 11, 2023
@TorstenStueber
Copy link
Member

@prayagd I would continue to be agile and not prioritize this ticket. No urgency for this at the moment.

@prayagd
Copy link
Collaborator Author

prayagd commented Jan 25, 2024

@TorstenStueber agree and hence put this on hold

@vadaynujra
Copy link

@prayagd in light of the off ramp feature we're building, how do we plan to get the initial liquidity to Nabla for the stablecoins? When would an LP incentives feature be required on Nabla?

@TorstenStueber
Copy link
Member

I think we should plan this around how we are going to use Nabla or its different instances in the next couple of months.

@vadaynujra
Copy link

If we want organic liquidity, we would need to consider incentivising LPers, at least initially, when the swap traction is low.
We could do this manually but on-chain rewards would just be simpler, though implementing it might not be.
@TorstenStueber what would this kind of plan look like?

@TorstenStueber
Copy link
Member

I think we should not make these assumptions preemptively before we actually see Nabla in action and observe pain points. Could very well be that we find another solution for liquidity where we don't need to incentivize through farming.

Considering the effort that went into Nabla, I think that this would be quite some effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:on-hold feature/fix is on hold due to external reasons (please specify)
Projects
None yet
Development

No branches or pull requests

5 participants