Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research the farming smart contract for Nabla #306

Closed
prayagd opened this issue Sep 14, 2023 · 10 comments
Closed

Research the farming smart contract for Nabla #306

prayagd opened this issue Sep 14, 2023 · 10 comments
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented Sep 14, 2023

Context

In order to distribute farming rewards to Nabla LP providers, we need to research the farming smart contract shared from the Nabla team.

Requirements

  • Can this smart contract be transpiled to WASM?
  • Can we use the transpiled smart contract as is or do we need to write additional code for it?
  • What are the parts smart contract need to rewritten?

Note

Smart contract - https://github.com/0xlaozi/qidao/blob/main/contracts/StakingRewards.sol

Research

The research results are available in this Notion page.

@prayagd
Copy link
Collaborator Author

prayagd commented Sep 14, 2023

Hey team! Please add your planning poker estimate with Zenhub @adelarja @b-yap @ebma @TorstenStueber

@TorstenStueber
Copy link
Member

Where is this coming from? I though that Nabla is self-contained and sufficient for our needs, I did not expect that we need to deploy other smart contracts.

@prayagd
Copy link
Collaborator Author

prayagd commented Oct 11, 2023

@TorstenStueber this is for distributing rewards for farming LP tokens, the Nabla smart contracts does not include this. This is an additional one.

@gianfra-t gianfra-t self-assigned this Oct 20, 2023
@ebma
Copy link
Member

ebma commented Dec 6, 2023

@gianfra-t I can see that this ticket is in the review column but it doesn't mention any research document in the description. Can you please update it so that it reflects the current state?

@gianfra-t
Copy link
Contributor

Sorry, I forgot to add it here. The research is in this notion page

@ebma
Copy link
Member

ebma commented Dec 6, 2023

Nice, thank you. The research looks good 👍 So we can conclude that the provided smart contract can be used for farming with just a minor modification.

I'd consider this ticket done then.

@ebma ebma closed this as completed Dec 6, 2023
@prayagd
Copy link
Collaborator Author

prayagd commented Dec 7, 2023

@ebma i see we need to use a SafeERC20 library to make the smart contract compatible with Pendulum. Should the followup ticket be deployment of that farming smart contract along with the SafeERC20 library?

@gianfra-t
Copy link
Contributor

There is a SafeERC20 implementation in the nabla repo if it is useful.

@ebma
Copy link
Member

ebma commented Dec 7, 2023

Should the followup ticket be deployment of that farming smart contract along with the SafeERC20 library?

Yes, if you want to have the farming feature, then the follow-up ticket should be about deploying the farming contract mentioned in this ticket together with the SafeERC20 contract used by Nabla.

@prayagd
Copy link
Collaborator Author

prayagd commented Dec 8, 2023

Cool, new ticket here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants