Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix muse: repo owner changed #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix muse: repo owner changed #14

wants to merge 1 commit into from

Conversation

QuintenQVD0
Copy link
Contributor

Description

GITHUB_PACKAGE="codetheweb/muse" -> GITHUB_PACKAGE="museofficial/muse"

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

@redthirten
Copy link
Contributor

I can't do it at the moment, but do you mind if I take a look and possibly add some stuff to the branch? Just some small clean-up stuff. I can probably do it either tonight or tomorrow.

@QuintenQVD0
Copy link
Contributor Author

I can't do it at the moment, but do you mind if I take a look and possibly add some stuff to the branch? Just some small clean-up stuff. I can probably do it either tonight or tomorrow.

Do whatever you like to this branch.

@redthirten
Copy link
Contributor

redthirten commented Dec 18, 2024

@TubaApollo Would you like to continue maintaining this Egg btw? Or would you like me to take over? Just want your permission before I change the Readme (and possibly the install script).

@redthirten
Copy link
Contributor

@QuintenQVD0 Their README states:

Node.js (18.17.0 or later is required and latest 18.x.x LTS is recommended)

Should we stick with what's recommended, or should we try to update it as far as it can go?

@QuintenQVD0
Copy link
Contributor Author

@QuintenQVD0 Their README states:

Node.js (18.17.0 or later is required and latest 18.x.x LTS is recommended)

Should we stick with what's recommended, or should we try to update it as far as it can go?

I saw that the install script uses node lts so I set the image to what the current lts version is.

@redthirten
Copy link
Contributor

@QuintenQVD0 Does the latest version of Muse work for you with this Egg?

@QuintenQVD0
Copy link
Contributor Author

@QuintenQVD0 Does the latest version of Muse work for you with this Egg?

It seems to not print out anything to the console. See museofficial/muse#1160

@redthirten
Copy link
Contributor

See museofficial/muse#1160

Yeh, see the latest posts from me on that Issue. I unfortunately don't know how to fix it, but it is Ptero specific :-/

@TubaApollo
Copy link
Contributor

TubaApollo commented Dec 19, 2024

@TubaApollo Would you like to continue maintaining this Egg btw? Or would you like me to take over? Just want your permission before I change the Readme (and possibly the install script).

Sure! Go ahead with taking it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants