run the install script as an entrypoint and not a cmd #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkervcp
requested changes
Sep 23, 2024
| @@ -403,7 +403,8 @@ func (ip *InstallationProcess) Execute() (string, error) { | |||
| AttachStdin: true, | |||
| OpenStdin: true, | |||
| Tty: true, | |||
| Cmd: []string{ip.Script.Entrypoint, "/mnt/install/install.sh"}, | |||
| Entrypoint: []string{ip.Script.Entrypoint, "/mnt/install/install.sh"}, | |||
There was a problem hiding this comment.
Why not set the entrypoint to nil and the command would stay the same?
There was a problem hiding this comment.
I tried that. It does not work.
There was a problem hiding this comment.
Does this throw an error or anything?
There was a problem hiding this comment.
No. Just does not set it at all. I have to redo this as it brakes images with a cmd set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is here for something very specific and not widely tested (yet).
I am making an egg for TiltedEvolution (SkyrimTogetherServer) and to get the server files they get pulled out of the install image as that are the only build server files and building them takes way to long.
The problem is that, that image entrypoint directly launches the game so the install script would never run. This is because we pass it to the cmd argument what runs after the entrypoint but of course that would never exit.
This PR forces to clear the cmd out of the selected image (if it has set one) and run the install script as the entrypoint.
edit: this does not work (turning the logic arround)
If wanted I could turn this arround and clear the entrypoint field and use the cmd field if wanted