Open
Conversation
…ame of a function referenced earlier
deweyx
commented
Mar 7, 2025
| character in this "scale of 64 characters". | ||
|
|
||
| The base64 scale starts with all ASCII uppercase letters (A to Z) which represents | ||
| the first 25 indexes in this scale (0 to 25). After that, we have all ASCII lowercase letters |
deweyx
commented
Mar 7, 2025
|
|
||
| Notice that we check if the indexes 2 and 3 in the temporary buffer are the number 64, which, if you recall | ||
| from @sec-map-base64-index, is when the `_calc_index()` function receives a `'='` character | ||
| from @sec-map-base64-index, is when the `_char_index()` function receives a `'='` character |
Author
There was a problem hiding this comment.
Seems to be referencing _char_index from earlier.
deweyx
commented
Mar 7, 2025
|
|
||
|
|
||
| Also, you might have notice that, if the input length is less than 3 bytes, then, the output length of the encoder is | ||
| Also, you might notice that, if the input length is less than 3 bytes, then, the output length of the encoder is |
Author
There was a problem hiding this comment.
If keeping "have" should then be "have noticed".
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These edits should be mostly non-controversial.
_calc_indexwhich is probably incorrect.Lastly, I assign the copyright of this contribution to Pedro Duarte Faria.