Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through style prop #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

athibaud
Copy link

for inline-style-needs

@pedronauck
Copy link
Owner

Really good, but when you create a new prop to use in the component you need to set this prop on propTypes, because the propTypes is good to maintain something like a manifest of component props. You got it?

Actually the lib has this props propTypes:

  propTypes: {
    from: React.PropTypes.oneOf(['youtube', 'vimeo']),
    videoId: React.PropTypes.string.isRequired,
    onError: React.PropTypes.func
  }

Please add the new prop, so I can merge the PR ;)

@athibaud
Copy link
Author

my bad! added style to propTypes now.
cheers!

@athibaud
Copy link
Author

squashed the commits. sorry for the trouble.
peace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants