Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text and background color #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AryanAhadinia
Copy link

Now with activeTextColor, you can separately control icon and text color. I had implemented activeBackgroundColor, so you can even control background color separated from icon and text color. These are optional fields, so compatibility will be maintained.

This PR can close both issues #65 and #52.

@Raider-hub
Copy link

Hello, please this is exactly what I wanted. I'm a flutter beginner, please how can I implement this in my project. This changes you've made. I also need an active Background color

@Raider-hub
Copy link

THIS IS THE ERRORS IM GETTING

lib/screens/home/bottom_navigator.dart:92:13: Error: No named parameter with the name 'activeBackgroundColor'.
activeBackgroundColor: Colors.grey,
^^^^^^^^^^^^^^^^^^^^^
/D:/src/flutter/.pub-cache/hosted/pub.dartlang.org/bottom_navy_bar-6.0.0/lib/bottom_navy_bar.dart:194:3: Context: Found this candidate, but the arguments don't match.
BottomNavyBarItem({

^^^^^^^^^^^^^^^^^

@AryanAhadinia
Copy link
Author

Hello,
Because this changed hasn't merged with master yet. You can use this feature after @pedromassango publish new version or you can add these changes manually to your project.

@Raider-hub
Copy link

Hello,
Because this changed hasn't merged with master yet. You can use this feature after @pedromassango publish new version or you can add these changes manually to your project.

Okay I understand. But please can you show me how I can Add this manually?

@baptistesx
Copy link

Hey @pedromassango, could you check this PR and merge it if everything is ok please? :)

Thanks in advance !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants