Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active color opacity level & gradient option #80

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

annasimoniaine
Copy link

@annasimoniaine annasimoniaine commented Apr 20, 2021

Added the option to set opacity level for the active color. Same changes as the first commit in pr #74 but from a new fork so there aren't any merge conflicts.
Also added the option to provide a list of colors to show a gradient instead of the active color background.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #80 (6ae5fd9) into master (2e88b51) will decrease coverage by 5.09%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   96.87%   91.78%   -5.10%     
==========================================
  Files           1        1              
  Lines          64       73       +9     
==========================================
+ Hits           62       67       +5     
- Misses          2        6       +4     
Impacted Files Coverage Δ
lib/bottom_navy_bar.dart 91.78% <71.42%> (-5.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e88b51...6ae5fd9. Read the comment docs.

@annasimoniaine annasimoniaine changed the title Active color opacity level Active color opacity level & gradient option Apr 20, 2021
@pedromassango pedromassango self-requested a review April 20, 2021 18:50
@pedromassango
Copy link
Owner

Hi @annasimoniaine
Thanks for this PR, will take a look shortly

@annasimoniaine
Copy link
Author

@pedromassango have you had a chance to look at this?

Copy link
Owner

@pedromassango pedromassango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @annasimoniaine
Thank you so much for this PR.

Can you please assert that both activeColor and activeBackgroundColorGradient most not be provided? User must be able to provide only one of them.

A test would also be required to merge this PR to make this does not break in the future.
Thank you

Copy link
Owner

@pedromassango pedromassango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

@annasimoniaine
Copy link
Author

Hi @pedromassango I added the assert and a test. Let me know if I need to add anything else.

Copy link
Owner

@pedromassango pedromassango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR, this should get merged soon.

@HugoHeneault
Copy link

HugoHeneault commented Jan 7, 2022

Hello @pedromassango, and thanks @annasimoniaine :)

I'm quite interested in this one, will you merge soon?

Using

  bottom_navy_bar:
    git:
      url: https://github.com/annasimoniaine/bottom_navy_bar/
      ref: 6ae5fd

for now but don't like to depends on git for pubs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants