Add support to override item width and item selected width #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 79.74% 78.31% -1.44%
==========================================
Files 1 1
Lines 79 83 +4
==========================================
+ Hits 63 65 +2
- Misses 16 18 +2
Continue to review full report at Codecov.
|
pedromassango
requested changes
Feb 16, 2021
Comment on lines
+16
to
+17
| this.itemSelectedWidth = 130, | ||
| this.itemWidth = 50, |
There was a problem hiding this comment.
Hi @davidpatrickcoleman
Thanks for this amazing contibution. Since this is a new feature could you please add tests to prevent this feature to break in the future?
Thank you
Sorry for the later feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overflow error appears if 5 tabs are displayed on smaller screen resolutions such as iPhone SE
Add ability to change the hardcoded item width (default 50) and item (default 130) in order to accommodate smaller screens (for example, reduce selected width to 110 and default width to 40).