-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shadows, rounded corners and more customization options. #67
base: master
Are you sure you want to change the base?
Conversation
lib/bottom_navy_bar.dart
Outdated
@@ -121,7 +158,7 @@ class _ItemWidget extends StatelessWidget { | |||
curve: curve, | |||
decoration: BoxDecoration( | |||
color: | |||
isSelected ? item.activeColor.withOpacity(0.2) : backgroundColor, | |||
isSelected ? item.activeColor.withOpacity(0.1) : backgroundColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to have activeOpacity
as constructor option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pawelpetruch
I agree with @omidraha it will be better to have this as constructor argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm moving it to the constructor.
lib/bottom_navy_bar.dart
Outdated
color: Colors.black12, | ||
blurRadius: 2, | ||
BoxShadow( | ||
color: Colors.black, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to have BoxShadow.color
or BoxShadow
as constructor option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, lets move this into constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move the color to the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for this PR.
Please see the comments and update the PR for me to take another look.
Thank you
Changes as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a new feature could you please add tests to prevent this feature to break in the future?
Thank you
padding: EdgeInsets.symmetric( | ||
vertical: verticalItemPadding, | ||
horizontal: horizontalItemPadding), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pawelpetruch
Thanks for this amazing contibution. Those two proerties could just be a Padding object so that users will have the hability to change a veri specific padding (left only, right only, top only, etc..)
Thank you
Sorry for the later feedback!
Hi all! Can you please implement the feature now? |
@jansvanda this PR needs requires some changes to be merged ( see #67 (comment)). |
This is the re-implementation of most of the work done on pedromassango#67 - however with a little bit missing and some optimization to the options.
Allows to add a custom shadow to the bar, opacity to the inactive icons, rounded corners and change the height of the tabs.