Skip to content

Aktualizace na fix false positive případů ++$i #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Aktualizace na fix false positive případů ++$i #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f6e5f3
Aktualizace na fix false positive případů ++
MilanPala Mar 16, 2021
f4a3980
DeclareStrictType chceme na prvním řádku
MilanPala Mar 8, 2021
38fbd6c
Nevyužité private property hlídá PHPStan
MilanPala Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ test:
./vendor/bin/phpcs --standard=src/PeckaCodingStandardStrict/ruleset.xml tests/Success/
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Arrays/TrailingArrayComma.php | tests/errorNumber.sh 1
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/ClassConstantVisibility.php | tests/errorNumber.sh 1
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/UnusedPrivateElements.php | tests/errorNumber.sh 2
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/PropertySpacing.php | tests/errorNumber.sh 2
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/MethodSpacingSniff.php | tests/errorNumber.sh 2
./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/ClassMemberSpacing.php | tests/errorNumber.sh 1
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"description": "Coding standard pro PeckaDesign",
"require": {
"php": "7.* || 8.*",
"squizlabs/php_codesniffer": "3.*",
"slevomat/coding-standard": "6.4.*",
"squizlabs/php_codesniffer": "dev-master as 3.5.99",
"slevomat/coding-standard": "dev-master as 6.4.99",
"escapestudios/symfony2-coding-standard": "3.*"
},
"license": "MIT",
Expand Down
1 change: 0 additions & 1 deletion src/PeckaCodingStandard/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<rule ref="Generic.Classes.DuplicateClassName"/>
<rule ref="Squiz.Classes.LowercaseClassKeywords"/>
<rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility"/>
<rule ref="SlevomatCodingStandard.Classes.UnusedPrivateElements"/>
<rule ref="SlevomatCodingStandard.Classes.PropertySpacing">
<properties>
<property name="minLinesCountBeforeWithComment" value="1"/>
Expand Down
6 changes: 5 additions & 1 deletion src/PeckaCodingStandardStrict/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
<rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>

<!-- TypeHints -->
<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes"/>
<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
<properties>
<property name="declareOnFirstLine" value="true" />
</properties>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint"/>

<!-- Namespaces -->
Expand Down
19 changes: 0 additions & 19 deletions tests/Failure/Classes/UnusedPrivateElements.php
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions tests/Success/Classes/UnusedPrivateElements.php
View file
Open in desktop

This file was deleted.