Skip to content

Issue #644 ch9 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue #644 ch9 #1033

wants to merge 3 commits into from

Conversation

coco3427
Copy link

@coco3427 coco3427 commented May 15, 2025

adds space before progress bar for #644

Description

I added a extra space before the progress bar in the same manner as @wrigjl for all sections in ch9, ch5 still needs to be done.

I cant see the task bar on my local host, because i don't have the full Runestone environment, but i think its correct.

How Has This Been Tested?

I cant see the task bar on my local host, because i don't have the full Runestone environment, but i think its correct.

@wrigjl
Copy link
Contributor

wrigjl commented May 15, 2025

Please don't mark your pull request as in-progress unless you do -not- want it merged. The normal usage for draft/work-in-progress is when you need commentary on it. There's nothing to discuss on these types of PRs.

@coco3427 coco3427 marked this pull request as ready for review May 16, 2025 14:39
@wrigjl
Copy link
Contributor

wrigjl commented May 28, 2025

@coco3427 I think some of the other changes that have gone in have conflicted with your changes. I think this PR should be updated (resolve the conflicts) and then ask Jan to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants