-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1208904834486479 evm compatible generate tx did #33
base: dev
Are you sure you want to change the base?
Feature/1208904834486479 evm compatible generate tx did #33
Conversation
@@ -31,7 +34,23 @@ describe('Ethereum Did', () => { | |||
* Tests the generation of a DID operations for ethereum tx values | |||
*/ | |||
describe('test ethereum did()', () => { | |||
it('test create did tx', async () => { | |||
it('test create did tx and send', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how a user would use the sdk.
|
||
constructor() { | ||
super(); | ||
} | ||
|
||
// how should a tx be created? | ||
// sdk.eth.did.create() | ||
public async create(options: CreateDidOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tx creation the same as was done in the particle-peaq-demo/src/App.tsx
abiCoder: ethers.AbiCoder = new ethers.AbiCoder(); | ||
value: Did = new Did(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to did
First iteration of building evm transactions that call peaq precompiles. Idea is to create an evm tx object that the user can send using their wallet on their end.
Used reference code from @irediaes implementation to expedite the process. Asana ticket.
Please look at create() function and once it is given the greenlight, read(), update(), and remove() functions will be added to this class.