Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual snapshot tests #82

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add visual snapshot tests #82

merged 4 commits into from
Jan 17, 2024

Conversation

pdil
Copy link
Owner

@pdil pdil commented Jan 17, 2024 •
edited
Loading

  • Added vdiffr-based tests for plot_usmap()
  • Renamed rivers data set to usrivers to avoid clash with datasets::rivers package
  • Fixed missing citypop.xlsx file and rebuilt all data sets

resolves #80

@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Jan 17, 2024
@pdil pdil self-assigned this Jan 17, 2024
@pdil pdil added this to the v0.7.0 milestone Jan 17, 2024
@pdil pdil force-pushed the feature/add-visual-tests branch from fad348a to 0918cc8 Compare January 17, 2024 21:46
@pdil pdil marked this pull request as ready for review January 17, 2024 21:46
@pdil pdil merged commit 01f7420 into master Jan 17, 2024
8 checks passed
@pdil pdil deleted the feature/add-visual-tests branch January 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Add snapshot testing for plots
1 participant
@pdil