Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow improvements #106

Merged
merged 11 commits into from
Mar 31, 2024
Merged

Conversation

pdil
Copy link
Owner

@pdil pdil commented Mar 31, 2024

Changes

  • Added version check in release.yaml workflow.
  • Added custom run-name based on the provided version number in release.yaml
  • Set all common workflows to call usmapdata workflows.

Notes

  • If the provided version is lower than the current, the workflow will fail.
  • Workflow re-use via workflow_call will allow for workflows to be updated for both usmap and usmapdata simultaneously.
    • usmapdata will be where the full workflow scripts are stored, reflecting the dependency usmap has on usmapdata for R code.

closes #105

@pdil pdil added enhancement A suggestion or feature that improves existing functionality tech Technical issues and pull requests not directly related to usmap functionality labels Mar 31, 2024
@pdil pdil self-assigned this Mar 31, 2024
@pdil pdil force-pushed the feature/release-workflow-improvements branch from ce3109d to bb9d3e9 Compare March 31, 2024 02:11
@pdil pdil force-pushed the feature/release-workflow-improvements branch from 23ffd1f to 468b5a9 Compare March 31, 2024 02:17
@pdil pdil removed the enhancement A suggestion or feature that improves existing functionality label Mar 31, 2024
@pdil pdil force-pushed the feature/release-workflow-improvements branch from 26c93f9 to a9c01f8 Compare March 31, 2024 03:43
@pdil pdil force-pushed the feature/release-workflow-improvements branch from 0deb97b to c0ae157 Compare March 31, 2024 21:24
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pdil pdil force-pushed the feature/release-workflow-improvements branch 2 times, most recently from d907c4d to 2f43f78 Compare March 31, 2024 21:38
@pdil pdil force-pushed the feature/release-workflow-improvements branch from 2f43f78 to eeb8959 Compare March 31, 2024 21:39
@pdil pdil marked this pull request as ready for review March 31, 2024 22:39
@pdil pdil merged commit 2628aa0 into master Mar 31, 2024
8 checks passed
@pdil pdil deleted the feature/release-workflow-improvements branch March 31, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release workflow improvements
1 participant