Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACOS compile with user_code plugin #551

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

Yushan-Wang
Copy link
Member

@Yushan-Wang Yushan-Wang commented Mar 10, 2025

When trying to compile the user-code plugin on macOS, the compiler could not find the header link.h

List of things to check before making a PR

Before merging your code, please check the following:

  • you have added a line describing your changes to the Changelog;
  • you have added unit tests for any new or improved feature;
  • In case you updated dependencies, you have checked pdi/docs/CheckList.md
  • you have checked your code format:
    • you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • you have checked that the indentation and formatting conforms to the .clang-format;
    • you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • your institution is in the copyright header of every file you (substantially) modified;
    • you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • you have added yourself to the AUTHORS file;
    • if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • any new CMake configuration option;
    • any change in the yaml config;
    • any change to the public or plugin API;
    • any other new or changed user-facing feature;
    • any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • your MR solves an identified issue;
    • your commit contain the Fix #issue keyword to autoclose the issue when merged.

@Yushan-Wang Yushan-Wang linked an issue Mar 10, 2025 that may be closed by this pull request
tpadioleau
tpadioleau previously approved these changes Mar 10, 2025
Copy link
Contributor

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yushan-Wang Yushan-Wang requested a review from jbigot March 11, 2025 09:46
Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add an issue about adding a MacOS runner for the tests

Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Yushan-Wang Yushan-Wang self-assigned this Mar 12, 2025
Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #555

@jbigot
Copy link
Member

jbigot commented Mar 20, 2025

I would recommend to make separate branches that each start from main and handle one issue and then make a branch that merge them all on your side for testing

@Yushan-Wang
Copy link
Member Author

I would recommend to make separate branches that each start from main and handle one issue and then make a branch that merge them all on your side for testing

Sure, I'll do that!

@Yushan-Wang Yushan-Wang merged commit b15ca9a into main Mar 20, 2025
34 checks passed
@Yushan-Wang Yushan-Wang deleted the 539-could-not-compile-the-plugin-user-code-on-macos branch March 20, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not compile the plugin user-code on macOS
4 participants