-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Catalyst Plugin. #496
base: main
Are you sure you want to change the base?
Add Catalyst Plugin. #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add Kitware to the copyright at the top of the root CMakeLists.txt you contributed to
Thank you so much for the contribution @francois-kitware ! From our point of view, it's basically good to go as-is, if you maintain the plugin separately in a submodule. We just need to add a Changelog entry, and some other minor elements related to our "checkboxes". Would you also be interested in the review of the plugin code? In this case, this should be done on your gitlab since from github we only have a submodule reference. |
d9b3078
to
98655ea
Compare
Add the catalyst plugin developed by Kitware as an official PDI plugin.
The plugin code have been copied in the branch and the catalyst library dependency is added as a submodule for easy update in the future.
When built with
BUILD_TESTING
CMake variable, the pdi-catalyst-plugin tests should pass:Looks like lots of boxes below are not checked. I'll update everything after PDI's team code review.
François
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format
;Fix #issue
keyword to autoclose the issue when merged.