Fix: fix reference url for GRCh37.p13 and GRCh38.p14 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrh
reviewed
Oct 29, 2024
| @@ -186,7 +186,7 @@ GRCh37.87.reference : http://useast.ensembl.org/info/data/ftp/index.html | |||
|
|
|||
| # GRCh37 release from NCBI's RefSeq | |||
| GRCh37.p13.genome : Human genome GRCh37 using RefSeq transcripts | |||
| GRCh37.p13.reference : https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.39_GRCh38.p13/ | |||
| GRCh37.p13.reference : https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.25_GRCh37.p13/ | |||
There was a problem hiding this comment.
Hi @pcingola Would it please be possible to have this fix in the next release? SnpEff is still incorrectly downloading GRCh38 instead of GRCh37. Thank you!
|
Pleas note that the Thank you for fixing the typo. |
|
Merged into the main branch separately. Closing the PR Thank you again and apologies for taking so long to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reference URLs in the config file:
https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.39_GRCh38.p13/tohttps://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.25_GRCh37.p13/https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.39_GRCh38.p14/tohttps://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/405/GCF_000001405.40_GRCh38.p14/