Maintenance: lint and remove unused code #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.9 and 3.10 behavior on the linearithmic test is a bit different and they fit correctly but with high residuals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak a little bit the parameters of the
big_otest because the performance behavior of the dummy functions we use for tests changes slightly between 3.9 and 3.10 and I needed to increasento make sure the behavior was nicely detectable.However, this made the test slow, and so I cut the number of timings. This is turn decreased the total measurement time and so I needed to adjust the maximum allowed residual, which at the moment is in absolute terms.
Other than that, this PR is just a clean-up of existing code