Add RW Lock to allComponentSchemas to Prevent Data Race Error

[califlower]

• solves issue Data Race using GetAllComponentSchemas #333
• Accessing GetAllComponentSchemas causes a race condition error during usage.
• Adds a RWLock to ensure that the map object is safely created across go routines. This pattern is used for other similar fields

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (5ac8657) to head (5c3c79d).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files         165      165              
  Lines       21050    21064      +14     
==========================================
+ Hits        20971    20983      +12     
- Misses         74       76       +2     
  Partials        5        5              

Flag	Coverage Δ
unittests	99.61% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[califlower]

I can add a test here, just wasn't sure about testing the race condition it was kind of difficult

[califlower]

I added a concurrent access test and a nil test. That should keep the coverage where it was at before

[califlower]

RIP. Doesn't seem like codecov is correct :<

[daveshanley]

The codecov is correct, I checked out your branch and this is what happens after running all tests.

The problem is the test.

func TestSpecIndex_GetAllComponentSchemas_NilIndex(t *testing.T) {
	index := &SpecIndex{}
	schemas := index.GetAllComponentSchemas()
	assert.Nil(t, schemas, "Expected GetAllComponentSchemas to return nil when index is nil")
}

index cannot be nil here, it will never be nil. To fix it:

func TestSpecIndex_GetAllComponentSchemas_NilIndex(t *testing.T) {
	var index *SpecIndex
	schemas := index.GetAllComponentSchemas()
	assert.Nil(t, schemas, "Expected GetAllComponentSchemas to return nil when index is nil")
}

[daveshanley]

Thank you for your contribution.

[califlower]

Ah my bad. Thank you for fixing it and merging! Really appreciate it!