Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added secondary parsing if the initial base path parsing fails; the s… #68

Conversation

jacobm-splunk
Copy link
Contributor

url.Parse does not handle special characters well.

Some openapi server configurations will have variable templating (ie. {host}).

This MR adds a second parsing attempt if the initial attempt fails by attempting to remove the host.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (6035624) to head (bbe8897).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          19       19           
  Lines        1737     1743    +6     
=======================================
+ Hits         1732     1738    +6     
  Misses          5        5           
Flag Coverage Δ
unittests 99.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! a lovely upgrade.

@daveshanley daveshanley merged commit 688b7a2 into pb33f:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants