getGlobalSessionID now checks if the storage already exists

src/globalSession.js

@@ -20,12 +20,17 @@ function getGlobalSessionStorage(): Storage {
   return getStorage({ name: getGlobalSessionName() });
 }
 
-function getGlobalStorageState<T>(handler: (storage: Object) => T): T {
-  return getGlobalSessionStorage().getState(handler);
-}
-
 export function getGlobalSessionID(): string | void {
-  const globalSessionID = getGlobalStorageState((state) => {
+  const storage = getGlobalSessionStorage();
+
+  if (
+    !storage ||
+    (storage.checkIfStorageExists && !storage.checkIfStorageExists())
+  ) {
+    return undefined;
+  }
+
+  const globalSessionID = storage.getState((state) => {
     if (
       !state ||
       typeof state !== "object" ||

src/globalSession.test.js

@@ -8,22 +8,24 @@ import {
 } from "./globalSession";
 
 let storageState = {};
+let storageExistsMock = vi.fn(() => true);
 
-vi.mock("@krakenjs/belter/src", async () => {
-  const actual = await vi.importActual("@krakenjs/belter/src");
+vi.mock("./global", async () => {
+  const actual = await vi.importActual("./global");
   return {
     ...actual,
-    getStorage: vi.fn(() => ({
-      getState: (handler) => handler(storageState),
-    })),
+    getVersion: vi.fn(() => "5.0.500"),
   };
 });
 
-vi.mock("./global", async () => {
-  const actual = await vi.importActual("./global");
+vi.mock("@krakenjs/belter/src", async () => {
+  const actual = await vi.importActual("@krakenjs/belter/src");
   return {
     ...actual,
-    getVersion: vi.fn(() => "5.0.500"),
+    getStorage: vi.fn(() => ({
+      getState: (handler) => handler(storageState),
+      checkIfStorageExists: () => storageExistsMock,
+    })),
   };
 });
 
@@ -80,4 +82,27 @@ describe("globalSession", () => {
     const globalSessionID = getGlobalSessionID();
     expect(globalSessionID).toBeUndefined();
   });
+
+  it("should return undefined if storage does not exist", () => {
+    storageExistsMock = vi.fn(() => false);
+    const globalSessionID = getGlobalSessionID();
+    expect(globalSessionID).toBeUndefined();
+    storageExistsMock = vi.fn(() => true);
+  });
+
+  it("should return undefined if storage is undefined", async () => {
+    const { getStorage } = await import("@krakenjs/belter/src");
+    // $FlowFixMe
+    getStorage.mockImplementation(() => undefined);
+    const globalSessionID = getGlobalSessionID();
+    expect(globalSessionID).toBeUndefined();
+  });
+
+  it("should return unknown version if getVersion returns null", async () => {
+    const { getVersion } = await import("./global");
+    // $FlowFixMe
+    getVersion.mockImplementation(() => undefined);
+    const name = getGlobalSessionName();
+    expect(name).toBe("paypal_global_unknown");
+  });
 });

vitestSetup.js

@@ -3,7 +3,10 @@ import { sdkClientTestGlobals } from "./test/globals";
 
 const applyEnvs = () => {
   Object.keys(sdkClientTestGlobals).forEach((k) => {
-    window[k] = sdkClientTestGlobals[k];
+    // Skip crypto property as it cannot be directly assigned
+    if (k !== "crypto") {
+      window[k] = sdkClientTestGlobals[k];
+    }
   });
 };