Skip to content

fix(plugin-search): serialize reindexing to prevent locale data race conditions #15917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ossaidqadri wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Open

fix(plugin-search): serialize reindexing to prevent locale data race conditions #15917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae31d8
docs: correct type name in editMenuItems client component example
ossaidqadri Mar 11, 2026
33919c6
fix(plugin-search): serialize reindexing to prevent locale data race …
ossaidqadri Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/custom-components/edit-view.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,9 @@ export const EditMenuItems = async (props: EditMenuItemsServerProps) => {
import React from 'react'
import { PopupList } from '@payloadcms/ui'

import type { EditViewMenuItemClientProps } from 'payload'
import type { EditMenuItemsClientProps } from 'payload'

export const EditMenuItems = (props: EditViewMenuItemClientProps) => {
export const EditMenuItems = (props: EditMenuItemsClientProps) => {
const handleClick = () => {
console.log('Custom button clicked!')
}
Expand Down
6 changes: 2 additions & 4 deletions packages/plugin-search/src/utilities/generateReindexHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,17 +196,15 @@ export const generateReindexHandler =
const shouldCommit = await initTransaction(req)

try {
const promises = collections.map(async (collection) => {
for (const collection of collections) {
try {
await deleteIndexes(collection)
await reindexCollection(collection)
} catch (err) {
const message = t('error:unableToReindexCollection', { collection })
payload.logger.error({ err, msg: message })
}
})

await Promise.all(promises)
}
} catch (err: any) {
if (shouldCommit) {
await killTransaction(req)
Expand Down
Loading