fix(ui): slugField validation error hiding Unlock / Lock button (#14827)#15885
Open
noahbachmann wants to merge 3 commits intopayloadcms:mainfrom
Open
fix(ui): slugField validation error hiding Unlock / Lock button (#14827)#15885noahbachmann wants to merge 3 commits intopayloadcms:mainfrom
noahbachmann wants to merge 3 commits intopayloadcms:mainfrom
Conversation
noahbachmann
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
noahbachmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #14827
What?
When there is a validation error with the slugField (e.g. empty field), the FieldError renders above the "Unlock"-Button. The user can't interact with this button and they are locked out of unlocking the slugField-input.
How?
Tooltip already has a property to change its position (position?: 'bottom' | 'top'). I added this nullable prop to FieldError / GenericErrorProps (readonly position?: 'bottom' | 'top').
Then i used the TextInput.props.Error inside fields/Slug by creating a FieldError with props.position = "bottom" (before this, it used the fallback FieldError inside TextInput).
Overlap issue
You can see there is still an issue with the Tooltip overlapping. So i fixed the styling in the Tooltip/index.scss:
