fix(ui): open folder/document items in new tab on modifier click#15873
Open
mibragimov wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): open folder/document items in new tab on modifier click#15873mibragimov wants to merge 1 commit intopayloadcms:mainfrom
mibragimov wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…odifiers Folder list rows and folder cards currently navigate via router.push on interaction, so modifier-click behaviors (cmd/ctrl/shift) do not open a new tab like regular links. This change adds modifier-aware navigation: - cmd/ctrl/shift + click now opens the target folder/document in a new tab - regular click/double-click behavior continues to route in the current tab Fixes payloadcms#15837
mibragimov
changed the title
mibragimov
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix folder/document navigation in folder views so modifier-click behaves like normal links.
cmd/ctrl/shift+ click on folder cards or list rows currently routes in-place viarouter.push, which prevents opening in a new tab.This PR adds modifier-aware behavior:
cmd/ctrl/shift+ click opens the target in a new tabChanges
navigateAfterSelectionwith anopenInNewTaboption.window.open(targetURL, '_blank', 'noopener,noreferrer').openInNewTab.Validation
pnpm exec eslint packages/ui/src/providers/Folders/index.tsxCloses #15837