-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: user updatedAt modified during session operations #14269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrikKozak
wants to merge
3
commits into
main
Choose a base branch
from
fix/session-operations-updating-updatedAt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
updatedAt
field on user documents was being updated whenever session operations occurred (login, logout, or token refresh), even though only session metadata was changing and not the actual user data itself.Why?
This behavior was introduced in PR #13335, which added explicit
updatedAt = new Date().toISOString()
to all session operations to ensure thatupdatedAt
would always be bumped when usingpayload.db.updateOne()
.However, this was incorrect for session operations specifically. The
updatedAt
timestamp should only change when the user's actual data (email, password, profile fields, etc.) is modified - not when internal session tracking metadata changes. Session management is essentially bookkeeping and shouldn't trigger timestamp updates that suggest the user entity itself was modified.How?
Modified session operations to set
updatedAt = null
instead of updating it:addSessionToUser()
inpackages/payload/src/auth/sessions.ts
logoutOperation()
inpackages/payload/src/auth/operations/logout.ts
refreshOperation()
inpackages/payload/src/auth/operations/refresh.ts
Setting
updatedAt = null
skips updating this field entirely, leaving the existing timestamp unchanged.Fixes #13626