feat: accept multiple locales in fallbackLocale #13822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
jessrynkar
force-pushed
the
feat/multiple-fallback-locales
branch
from
18e2d2c to
b8898ee
Compare
JarrodMFlesch
requested changes
Oct 2, 2025
Comment on lines
+58
to
+68
| if ( | ||
| typeof fallbackLocale === 'string' && | ||
| fallbackLocale.startsWith('[') && | ||
| fallbackLocale.endsWith(']') | ||
| ) { | ||
| fallbackLocale = fallbackLocale | ||
| .slice(1, -1) | ||
| .split(',') | ||
| .map((l) => l.trim()) | ||
| } | ||
|
|
There was a problem hiding this comment.
This feels out of place. Seems like any logic like this should be done outside of this function and the fallbackLocale should then be passed in. Not sure about the string manipulation here. Feels like we should be able to get the fallbackLocale off of the parsed params and pass it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change allows
fallbackLocaleto accept an array of locales in find queries and locale configuration.Why?
This update is part of the planned localization enhancements. Currently, only one fallback locale can be specified. If that locale doesn’t contain data, the query returns nothing. To work around this, users have to inspect the response themselves and then make additional queries for other locales.
With this change, Payload handles that work automatically. Users only need to provide a list of fallback locales in their preferred order, and Payload will check each one until it finds a value.
How?
Updates query handling across the local API, REST API, and GraphQL so that
fallbackLocalecan accept either a string or an array of locales. When an array is passed, Payload will iterate through them in order and return the first found localized value. This behavior applies to both collections and globals.Feature request: #13443